Source code small bugs [1.0.7.4]

[gob33]

ver 1.0.7.4, MySQL >= 5.0


[1] - FILE : admin/modules/maindisplay/customer.detail.php
Lines 64-77 : PHP Parse errors
   Missing the last </select>.
   Short tags used <? ... ?> and <?= ... ?> (depends of server php.ini settings).
Line 159:
   "Discount - Users discount in %"   not translated.


[2] - FILE : admin/functions/navigation.func.php
Line 483 :
   Should be 'customer.php?obj=detail' without an 's', because of the switch in customer.main.php.


[3] - FILE : admin/actions/document.delete.verify.act.php
Line 28 :
   No corresponding character '`' after Documents which perturbs the SQL command
   when deleting a few documents:
   $sql['documents']   = "select `image` from `{$config['prefix']}Documents where "

[softnow]

FILE : admin/modules/maindisplay/customer.detail.php
Lines 64-77 : PHP Parse errors
   Missing the last </select>.
   Short tags used <? ... ?> and <?= ... ?> (depends of server php.ini settings).
Line 159:
   "Discount - Users discount in %"   not translated.

To fix the error
find this

Code:

<select name="gender">
<?php
            if ($info['customer']['gender'])
            {
?>
            <option value="0"><?=$output['1724']?></option>
            <option value="1" selected="selected"><?=$output['1725']?></option>
<?
            } else {
?>
            <option value="0" selected="selected"><?=$output['1724']?></option>
            <option value="1"><?=$output['1725']?></option>
<?
                                }
          ?>
        </td></tr>

and replace with this

Code:

<select name="gender">
<?php
            if ($info['customer']['gender'])

?>
            <option value="0"><?$output['1724']?></option>
            <option value="1" selected="selected"><?php echo $output['1725']?></option>
<?php
             else
?>
            <option value="0" selected="selected"><?php echo $output['1724']?></option>
            <option value="1"><?$output['1725']?></option>
<?php

          ?>
         
        </td></tr>

Discount -Users discount in % shows fine it doesn't post to the database so have asked the moderator that wrote this change to update the files

FILE : admin/functions/navigation.func.php
Line 483 :
   Should be 'customer.php?obj=detail' without an 's', because of the switch in customer.main.php.

My version of 1.0.7.4 clean un zip doesn't have the extra s in customers

[gob33]

You must use <?php..?> tags instead of <?...?> because its depends of server settings and of your provider.


[4] - FILE : admin/modules/maindisplay/methods.create.php
Line 51:
   Typo error : '$payemnt_directory'


[5] - FILE : _install.php
   Failure when creating a newsletter with no attachement.
   Cause: the table field 'attachement' defined as NOT NULL, must have a default value.
   This prevents the insertion in 'admin/actions/newsletter.create.act.php' of a new
   newsletter with   no attachement.
   Should be :
      `attachment` VARCHAR(250) NOT NULL DEFAULT '',
   or
      `attachment` VARCHAR(250),

[6] - FILE : _install.php
   Failure when creating a product in admin/action/product.create.category.act.php
   Cause: the table field 'description' defined as NOT NULL, must have a default value.
   This prevents the insertion in 'admin/actions/product.create.category.act.php' of a new
   product with no description at this point.
   Should be :
      description TEXT NOT NULL default '',
   or
      description TEXT,

[7] - FILE : admin/langage/english.php
   Please, add the word 'other' for comprehension to
   $output['0995'] = "What other categories should this product be linked to?";

[8] - FILE : admin/actions/product.create.linked.act.php
Line 21:
   Failure when linking a new product to another category.
   Cause: the table field 'modified' is defined as NOT NULL.
   The INSERT statement must have the field 'modified' with a value of 'NOW()'

[cpradio]

All of these were incorporated in v1.0.9

[gob33]

Bugs resolved in v1.1.0 and checked, except [5] and [6].
So I reopen this subject.

[5] -FILE : _install.php
   Create a dummy newsletter (News01) with no attachement.
   Submit and look in database: nothing

   Cause: the table field 'attachement' defined as NOT NULL, must have a default value.
   This prevents the insertion in 'admin/actions/newsletter.create.act.php' of a new
   newsletter with   no attachement.
   Should be :
      `attachment` VARCHAR(250) NOT NULL DEFAULT '',
   or
      `attachment` VARCHAR(250),

[6] - FILE : _install.php
   Create a category (Cat01), then a manufacturer (Manu01). All is OK.
   Next step, create your first product (Prod01) attached to Cat01 and Manu01.
   The form is 'product.create.category.php'.
   Submit and look in database: nothing created.

   Cause: the table field 'description' of Products is defined as NOT NULL, must have
   a default value. This prevents the insertion of a new product at this point.
   Should be :
      description TEXT NOT NULL default '',
   or
      description TEXT,

   I deduce 2 points from that:
   1) the db functions of _dbquery.php pass silently on database errors.
   2) nobody has cpCommerce with MySQL 5.0 in production.

There has been several posts about that pb.

[softnow]

[6] - FILE : _install.php
   Create a category (Cat01), then a manufacturer (Manu01). All is OK.
   Next step, create your first product (Prod01) attached to Cat01 and Manu01.
   The form is 'product.create.category.php'.
   Submit and look in database: nothing created.

   Cause: the table field 'description' of Products is defined as NOT NULL, must have
   a default value. This prevents the insertion of a new product at this point.
   Should be :
      description TEXT NOT NULL default '',
   or
      description TEXT,

   I deduce 2 points from that:
   1) the db functions of _dbquery.php pass silently on database errors.
   2) nobody has cpCommerce with MySQL 5.0 in production.

There has been several posts about that pb.

I am running mysql 5.0.22 and do not have this problem

[cpradio]

I have these corrected on my machine now.